lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 04 Dec 2012 13:17:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gregkh@...uxfoundation.org
Cc:	netdev@...r.kernel.org, wfp5p@...ginia.edu
Subject: Re: [GIT PULL] Remove __dev* markings from the networking drivers

From: David Miller <davem@...emloft.net>
Date: Mon, 03 Dec 2012 15:36:23 -0500 (EST)

> From: Greg KH <gregkh@...uxfoundation.org>
> Date: Mon, 3 Dec 2012 12:27:43 -0800
> 
>> Here's a pull request for all of Bill's __dev* removal patches for the
>> networking drivers, based on net-next.  I'll send out a separate one for
>> the wireless drivers in case those want to go through John's tree
>> 
>> If I should rework these in any way, please let me know.
> 
> Pulled, thanks Greg.

I had a reason to go look in detail at the changes in here.

It seemse the function declarations were not properly reformatted
after the __dev* tags were removed.  You can't just search and replace
this kind of stuff.  The result looks terrible.

Greg please check for things like this next time you send me changes
written by someone else.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ