netdev - Re: [PATCH net-next] myri10ge: fix most sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121205.162546.1187131916097405931.davem@davemloft.net>
Date:	Wed, 05 Dec 2012 16:25:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	gallatin@...i.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] myri10ge: fix most sparse warnings

From: Andrew Gallatin <gallatin@...i.com>
Date: Tue,  4 Dec 2012 15:17:15 -0500

> - convert remaining htonl/ntohl +__raw_read/__raw_writel to
>   swab32 + readl/writel
> - add missing __iomem qualifier in myri10ge_open()
> - fix  dubious: x & !y warning by switching from logical to bitwise not
> 
> The swab32 conversion fixes a bug in myri10ge_led() where
> big-endian machines would write the wrong pattern.
> 
> The only remaining warning (lock context imbalance) is due to
> the use of __netif_tx_trylock(), and cannot easily be fixed.
> 
> Signed-off-by: Andrew Gallatin <gallatin@...i.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html