netdev - Re: [PATCH net-next v2] bridge: export multicast database via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1354673339.28951.3.camel@cr0>
Date:	Wed, 05 Dec 2012 10:08:59 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org,
	Herbert Xu <herbert@...dor.hengli.com.au>,
	"David S. Miller" <davem@...emloft.net>,
	Thomas Graf <tgraf@...g.ch>,
	Jesper Dangaard Brouer <brouer@...hat.com>
Subject: Re: [PATCH net-next v2] bridge: export multicast database via
 netlink

On Tue, 2012-12-04 at 08:53 -0800, Stephen Hemminger wrote:
> On Mon,  3 Dec 2012 21:03:43 +0800
> Cong Wang <amwang@...hat.com> wrote:
> 
> > V2: drop patch 1/2, export ifindex directly
> >     Redesign netlink attributes
> >     Improve netlink seq check
> >     Handle IPv6 addr as well
> > 
> > TODO: remove debugging printk's
> > 
> > This patch exports bridge multicast database via netlink
> > message type RTM_GETMDB. Similar to fdb, but currently bridge-specific.
> > We may need to support modify multicast database too (RTM_{ADD,DEL}MDB).
> > 
> > Cc: Herbert Xu <herbert@...dor.apana.org.au>
> > Cc: Stephen Hemminger <shemminger@...tta.com>
> > Cc: "David S. Miller" <davem@...emloft.net>
> > Cc: Thomas Graf <tgraf@...g.ch>
> > Cc: Jesper Dangaard Brouer <brouer@...hat.com>
> > Signed-off-by: Cong Wang <amwang@...hat.com>
> >     
> 
> Minor nit reported by checkpatch was the messages should be using the api
> which provides the most info in the log to identify.
> 
> WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> #190: FILE: net/bridge/br_mdb.c:28:
> +		printk(KERN_INFO "no router on bridge\n")
> 
> There is a set of macro's already for use in bridging code:
>                 br_info(br, "no router on bridge\n");
> 

Never mind, removing these printk's is in my TODO list. :)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html