[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50BFA5E5.6070307@gmail.com>
Date: Wed, 05 Dec 2012 20:52:05 +0100
From: Stephan Gatzka <stephan.gatzka@...il.com>
To: Richard Cochran <richardcochran@...il.com>
CC: netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [Patch 1/1] net/phy: Add interrupt support for dp83640 phy.
> The patch looks okay to me, but I worry that this might fail on boards
> which have not connected the phyer's PWERDOWN/INTN pin to anything.
> Such designs really need the PHY_POLL working.
> Taking a brief glance at the drivers for two such boards I know of
> (m5234bcc and an IXP), it looks like their MAC drivers set mii_bus irq
> to PHY_POLL, so it might work fine, but this patch still makes me
> nervous that some other board might break.
>
> Maybe this should be a kconfig option?
I don't think so.
Systems using device tree just don't specify the interrupt tag in the
mdio section.
I have to admit that I don't know how how systems without employing
device tree get the phy interrupt configured, maybe someone can explain
that shortly?
Nevertheless, other drivers for very common phys like the lxt971 also
just set the function pointers to config_intr and ack_interrupt and also
set the flag PHY_HAS_INTERRUPT. So I don't think that the my patch
breaks something.
Regards,
Stephan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists