netdev - Re: [net-next 6/8] bna: Add Stats Clear Counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Dec 2012 02:19:42 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Rasesh Mody <rmody@...cade.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<adapter_linux_open_src_team@...cade.com>
Subject: Re: [net-next 6/8] bna: Add Stats Clear Counter

On Wed, 2012-12-05 at 15:01 -0800, Rasesh Mody wrote:
> Added Stats clear counter to the bfi_enet_stats_mac structure and ethtool stats
>  
> Signed-off-by: Rasesh Mody <rmody@...cade.com>

Since this structure appears to be part of the firmware interface, you
should combine this (and any other interface changes) with the change to
the requested firmware version (7/8).

Ben.

> ---
>  drivers/net/ethernet/brocade/bna/bfi_enet.h     |    1 +
>  drivers/net/ethernet/brocade/bna/bnad_ethtool.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/ethernet/brocade/bna/bfi_enet.h b/drivers/net/ethernet/brocade/bna/bfi_enet.h
> index eef6e1f..7d10e33 100644
> --- a/drivers/net/ethernet/brocade/bna/bfi_enet.h
> +++ b/drivers/net/ethernet/brocade/bna/bfi_enet.h
> @@ -787,6 +787,7 @@ struct bfi_enet_stats_bpc {
>  
>  /* MAC Rx Statistics */
>  struct bfi_enet_stats_mac {
> +	u64 stats_clr_cnt;	/* times this stats cleared */
>  	u64 frame_64;		/* both rx and tx counter */
>  	u64 frame_65_127;		/* both rx and tx counter */
>  	u64 frame_128_255;		/* both rx and tx counter */
> diff --git a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
> index 40e1e84..455b5a2 100644
> --- a/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
> +++ b/drivers/net/ethernet/brocade/bna/bnad_ethtool.c
> @@ -102,6 +102,7 @@ static const char *bnad_net_stats_strings[BNAD_ETHTOOL_STATS_NUM] = {
>  	"rx_unmap_q_alloc_failed",
>  	"rxbuf_alloc_failed",
>  
> +	"mac_stats_clr_cnt",
>  	"mac_frame_64",
>  	"mac_frame_65_127",
>  	"mac_frame_128_255",

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html