netdev - Re: [PATCH] net: gro: fix possible panic in skb_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121207.144119.1859602274016402253.davem@davemloft.net>
Date:	Fri, 07 Dec 2012 14:41:19 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: gro: fix possible panic in skb_gro_receive()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 06 Dec 2012 15:54:59 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit 2e71a6f8084e (net: gro: selective flush of packets) added
> a bug for skbs using frag_list. This part of the GRO stack is rarely
> used, as it needs skb not using a page fragment for their skb->head.
> 
> Most drivers do use a page fragment, but some of them use GFP_KERNEL
> allocations for the initial fill of their RX ring buffer.
> 
> napi_gro_flush() overwrite skb->prev that was used for these skb to
> point to the last skb in frag_list.
> 
> Fix this using a separate field in struct napi_gro_cb to point to the
> last fragment.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html