netdev - Re: [PATCH net-next v3 1/3] virtio-net: separate fields of sending/receiving queue from virtnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121207151111.7d2f9150@samsung-9>
Date:	Fri, 7 Dec 2012 15:11:11 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jason Wang <jasowang@...hat.com>
Cc:	mst@...hat.com, rusty@...tcorp.com.au, davem@...emloft.net,
	virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, krkumar2@...ibm.com,
	kvm@...r.kernel.org, bhutchings@...arflare.com,
	jwhan@...ewood.snu.ac.kr, shiyer@...hat.com
Subject: Re: [PATCH net-next v3 1/3] virtio-net: separate fields of
 sending/receiving queue from virtnet_info

Minor style issue reported by checkpatch which can be fixed after merge.
Although sizeof is actually an operator in C, it is considered correct
style to treat it as a function.


WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr)
#293: FILE: drivers/net/virtio_net.c:395:
+	sg_set_buf(rq->sg, &hdr->hdr, sizeof hdr->hdr);

WARNING: sizeof hdr->mhdr should be sizeof(hdr->mhdr)
#552: FILE: drivers/net/virtio_net.c:641:
+		sg_set_buf(sq->sg, &hdr->mhdr, sizeof hdr->mhdr);

WARNING: sizeof hdr->hdr should be sizeof(hdr->hdr)
#555: FILE: drivers/net/virtio_net.c:643:
+		sg_set_buf(sq->sg, &hdr->hdr, sizeof hdr->hdr);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html