lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 07 Dec 2012 18:45:20 +0800 From: Shan Wei <shanwei88@...il.com> To: Cong Ding <dinggnu@...il.com> CC: "David S. Miller" <davem@...emloft.net>, "Eric W. Biederman" <ebiederm@...ssion.com>, Eric Dumazet <edumazet@...gle.com>, Pavel Emelyanov <xemul@...allels.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: core: fix unused variable sparse warning Cong Ding said, at 2012/12/7 8:15: > On Fri, Dec 07, 2012 at 12:06:44AM +0000, Cong Ding wrote: >> the variables zero and unres_qlen_max are only used when CONFIG_SYSCTL is >> defined, otherwise it causes the following sparse warning when we turn on >> CONFIG_SYSCTL. > sorry for disturbing again, the sparse warning is > net/core/neighbour.c:65:12: warning: ‘zero’ defined but not used [-Wunused-variable] > net/core/neighbour.c:66:12: warning: ‘unres_qlen_max’ defined but not used [-Wunused-variable] > > it happens if we turn off CONFIG_SYSCTL. It has been fixed yesterday. see b93196dc5af7729ff7cc50d3d322ab1a364aa14f > >> >> Signed-off-by: Cong Ding <dinggnu@...il.com> >> --- >> net/core/neighbour.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/net/core/neighbour.c b/net/core/neighbour.c >> index 36fc692..4a15278 100644 >> --- a/net/core/neighbour.c >> +++ b/net/core/neighbour.c >> @@ -62,8 +62,10 @@ static void __neigh_notify(struct neighbour *n, int type, int flags); >> static void neigh_update_notify(struct neighbour *neigh); >> static int pneigh_ifdown(struct neigh_table *tbl, struct net_device *dev); >> >> +#ifdef CONFIG_SYSCTL >> static int zero; >> static int unres_qlen_max = INT_MAX / SKB_TRUESIZE(ETH_FRAME_LEN); >> +#endif >> >> static struct neigh_table *neigh_tables; >> #ifdef CONFIG_PROC_FS >> -- >> 1.7.4.5 >> > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists