netdev - Re: [PATCH net-next v3 01/22] bnx2x: Support probing and removing of VF device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1355165459.26815.27.camel@joe-AO722>
Date:	Mon, 10 Dec 2012 10:50:59 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	ariele@...adcom.com, netdev@...r.kernel.org, eilong@...adcom.com
Subject: Re: [PATCH net-next v3 01/22] bnx2x: Support probing and removing
 of VF device

On Mon, 2012-12-10 at 13:35 -0500, David Miller wrote:
> From: "Ariel Elior" <ariele@...adcom.com>
> Date: Mon, 10 Dec 2012 17:46:25 +0200
[]
> > @@ -12023,85 +12057,115 @@ static int bnx2x_get_num_non_def_sbs(struct pci_dev *pdev,
> >        * If MSI-X is not supported - return number of SBs needed to support
> >        * one fast path queue: one FP queue + SB for CNIC
> >        */
> > -     if (!pos)
> > +     if (!pos) {
> > +             pr_info("no msix capability found");
[]
> Use dev_info(), netdev_info(), or similar, rather than plain
> pr_info().

Also, please add terminating newlines to avoid
dmesg message interleaving.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html