netdev - Re: [net-next:master 195/198] net/bridge/br_mdb.c:79:35: sparse: incompatible types in comparison expression (different address spaces)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1355143004.11752.19.camel@cr0>
Date:	Mon, 10 Dec 2012 20:36:44 +0800
From:	Cong Wang <amwang@...hat.com>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next:master 195/198] net/bridge/br_mdb.c:79:35: sparse:
 incompatible types in comparison expression (different address spaces)

On Sun, 2012-12-09 at 10:54 +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head:   9ecb9aabaf634677c77af467f4e3028b09d7bcda
> commit: ee07c6e7a6f8a25c18f0a6b18152fbd7499245f6 [195/198] bridge: export multicast database via netlink
> 
> 
> sparse warnings:
> 
> + net/bridge/br_mdb.c:79:35: sparse: incompatible types in comparison expression (different address spaces)

Hi, Fengguang,

I am not sure if I understand this warning correctly. Does the following
patch fix it?

Thanks!

---------------->

diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c
index 2528328..0bc0e13 100644
--- a/net/bridge/br_mdb.c
+++ b/net/bridge/br_mdb.c
@@ -77,7 +77,7 @@ static int br_mdb_fill_info(struct sk_buff *skb,
struct netlink_callback *cb,
                        }
 
                        for (pp = &mp->ports;
-                            (p = rcu_dereference(*pp)) != NULL;
+                            (p = rcu_dereference_protected(*pp, 1)) !=
NULL;
                              pp = &p->next) {
                                port = p->port;
                                if (port) {


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html