lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 11 Dec 2012 12:57:53 -0800
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	Or Gerlitz <or.gerlitz@...il.com>
CC:	Amir Vadai <amirv@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yan Burman <yanb@...lanox.com>,
	Ben Hutchings <bhutchings@...arflare.com>
Subject: Re: [PATCH net-next 1/2] net: ethtool: Add destination MAC address
 to flow steering API

On 12/11/2012 11:55 AM, Or Gerlitz wrote:
> On Tue, Dec 11, 2012 at 7:37 PM, Alexander Duyck
> <alexander.h.duyck@...el.com> wrote:
>>
>> Is there any special reason why you need to change the size of this
>> structure?  It seems like you could probably just replace the data
>> section with a union containing either 8 bytes of user specified data or
>> your MAC address data.  Then we wouldn't need all of the changes to the
>> rest of the flow specifier.
> 
> 
> basically, we followed Ben's suggestions made here
> http://marc.info/?t=134977576500003
> 

After looking over Ben's suggestion it makes sense.

Since I am pretty much responsible for the ixgbe implementation of this
I will do a few quick tests once the patches are applied to make certain
that there were no issues introduced on our end.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists