netdev - Re: [PATCH] tun: allow setting ethernet addresss while running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2012 08:38:54 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jan Engelhardt <jengelh@...i.de>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [PATCH] tun: allow setting ethernet addresss while running

On Wed, 12 Dec 2012 04:27:54 +0100 (CET)
Jan Engelhardt <jengelh@...i.de> wrote:

> On Tuesday 2012-12-11 02:16, Stephen Hemminger wrote:
> 
> >This is a pure software device, and ok with live address change.
> >--- a/drivers/net/tun.c
> >+++ b/drivers/net/tun.c
> >@@ -849,6 +849,7 @@ static void tun_net_init(struct net_device *dev)
> > 		/* Ethernet TAP Device */
> > 		ether_setup(dev);
> > 		dev->priv_flags &= ~IFF_TX_SKB_SHARING;
> >+		dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> > 
> > 		eth_hw_addr_random(dev);
> 
> Would this possibly apply to L2TP devices as well?

L2TP does not allow changing mac address at all right now.
Only drivers that use eth_mac_addr, can take advantage of the flag.


Looking around here are the other places that could use it.
 vxlan, xen-netfront?, gre, gre6, virtio_net?, hyperv?

Also the following look buggy.
  c2 allows changing mac address but never tells hardware?
  isdn/hysdn_net.c allows setting mac address but then resets it
      card value in net_open
  xpnet allows setting address but it looks like it fixed by hardware
  ipddp allows ethernet address but protocol is not ethernet


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html