netdev - Re: [patch net-next 0/4] net: allow to change carrier from userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Dec 2012 18:05:20 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	bhutchings@...arflare.com, mirqus@...il.com,
	greearb@...delatech.com, fbl@...hat.com
Subject: Re: [patch net-next 0/4] net: allow to change carrier from userspace

Wed, Dec 12, 2012 at 05:15:00PM CET, shemminger@...tta.com wrote:
>On Wed, 12 Dec 2012 11:58:03 +0100
>Jiri Pirko <jiri@...nulli.us> wrote:
>
>> This is basically a repost of my previous patchset:
>> "[patch net-next-2.6 0/2] net: allow to change carrier via sysfs" from Aug 30
>> 
>> The way net-sysfs stores values changed and this patchset reflects it.
>> Also, I exposed carrier via rtnetlink iface.
>> 
>> So far, only dummy driver uses carrier change ndo. In very near future
>> team driver will use that as well.
>> 
>> Jiri Pirko (4):
>>   net: add change_carrier netdev op
>>   net: allow to change carrier via sysfs
>>   rtnl: expose carrier value with possibility to set it
>>   dummy: implement carrier change
>> 
>>  drivers/net/dummy.c          | 10 ++++++++++
>>  include/linux/netdevice.h    |  7 +++++++
>>  include/uapi/linux/if_link.h |  1 +
>>  net/core/dev.c               | 19 +++++++++++++++++++
>>  net/core/net-sysfs.c         | 15 ++++++++++++++-
>>  net/core/rtnetlink.c         | 10 ++++++++++
>>  6 files changed, 61 insertions(+), 1 deletion(-)
>> 
>
>I needed to do the same thing for a project we are working on and discovered
>that there already is a working documented interface for doing that via
>operstate mode. Therefore I can't recommend that the additional complexity
>of a new API for this is required.

I might be missing something, but I'm unable to find how operstate set
can affect value returned by netif_carrier_ok()
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html