netdev - Re: [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2 maximum response code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121213161201.6d2da433@nehalam.linuxnetplumber.net>
Date:	Thu, 13 Dec 2012 16:12:01 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Ang Way Chuang <wcang@....wide.ad.jp>
Cc:	netdev@...r.kernel.org, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH] bridge: Bug fix for incorrect interpretation of MLDv2
 maximum response code

On Fri, 14 Dec 2012 08:07:01 +0800
Ang Way Chuang <wcang@....wide.ad.jp> wrote:

> This patch fixes the incorrect interpretation of endianness of MLDv2 maximum response
> code within bridge's multicast snooping code.
> 
> Signed-off-by: Ang Way Chuang <wcang@....wide.ad.jp>
> ---
> diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> index 977c3ee..29c6283 100644
> --- a/net/bridge/br_multicast.c
> +++ b/net/bridge/br_multicast.c
> @@ -1172,7 +1172,7 @@ static int br_ip6_multicast_query(struct net_bridge *br,
>  		mld2q = (struct mld2_query *)icmp6_hdr(skb);
>  		if (!mld2q->mld2q_nsrcs)
>  			group = &mld2q->mld2q_mca;
> -		max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(mld2q->mld2q_mrc) : 1;
> +		max_delay = mld2q->mld2q_mrc ? MLDV2_MRC(ntohs(mld2q->mld2q_mrc)) : 1;
>  	}
>  
>  	if (!group)

Already fixed as part of my patch to fix sparse warnings.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html