netdev - Re: [RFC][PATCH] bgmac: driver for GBit MAC core on BCMA bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1355448075.13796.47.camel@joe-AO722>
Date:	Thu, 13 Dec 2012 17:21:15 -0800
From:	Joe Perches <joe@...ches.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [RFC][PATCH] bgmac: driver for GBit MAC core on BCMA bus

On Thu, 2012-12-13 at 20:24 +0100, Rafał Miłecki wrote:
> 2012/12/13 Joe Perches <joe@...ches.com>:
> > On Thu, 2012-12-13 at 18:43 +0100, Rafał Miłecki wrote:
> >> BCMA is a Broadcom specific bus with devices AKA cores. All recent BCMA
> >> based SoCs have gigabit ethernet provided by the GBit MAC core. This
> >> patch adds driver for such a cores registering itself as a netdev. It
> >> has been tested on a BCM4706 and BCM4718 chipsets.
[]
> >> +     /* Stats */
> >> +     bool stats_grabbed;
> >> +     u32 mib_tx_regs[BGMAC_NUM_MIB_TX_REGS];
> >> +     u32 mib_rx_regs[BGMAC_NUM_MIB_RX_REGS];
> >> +};
> >
> > Maybe some minor reordering of the u8/bools to reduce padding.
> 
> Really? Compiler won't do that for me? I hope that compiler optimizes
> structs (until using __packed) :(

The compiler is not allowed to reorder struct members.
Perhaps you bundle together all the u8/bools.
Maybe not when/where cachelines are crossed.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html