netdev - Re: [PATCH] Fix comment for packets without data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121216223825.GC1304@1984>
Date:	Sun, 16 Dec 2012 23:38:25 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Rick Jones <rick.jones2@...com>
Cc:	Florent Fourcot <florent.fourcot@...t-bretagne.fr>,
	yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] Fix comment for packets without data

On Fri, Dec 14, 2012 at 01:28:54PM -0800, Rick Jones wrote:
> On 12/14/2012 02:53 AM, Florent Fourcot wrote:
> >Remove ambiguity of double negation
> >
> >Signed-off-by: Florent Fourcot <florent.fourcot@...t-bretagne.fr>
> >---
> >  net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> >index 00ee17c..137e245 100644
> >--- a/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> >+++ b/net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c
> >@@ -81,8 +81,8 @@ static int ipv6_get_l4proto(const struct sk_buff *skb, unsigned int nhoff,
> >  	}
> >  	protoff = ipv6_skip_exthdr(skb, extoff, &nexthdr, &frag_off);
> >  	/*
> >-	 * (protoff == skb->len) mean that the packet doesn't have no data
> >-	 * except of IPv6 & ext headers. but it's tracked anyway. - YK
> >+	 * (protoff == skb->len) means the packet has not data, just
> >+	 * IPv6 and possibly extensions headers, but it is tracked anyway
> >  	 */
> >  	if (protoff < 0 || (frag_off & htons(~0x7)) != 0) {
> >  		pr_debug("ip6_conntrack_core: can't find proto in pkt\n");
> >
> 
> Acked-by: Rick Jones <rick.jones2@...com>

Applied, thanks.

That was many discussion for a patch to fix a comment, nice indeed :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html