netdev - Re: openconnect triggers soft lockup in __skb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121217081121.GA24173@shutemov.name>
Date:	Mon, 17 Dec 2012 10:11:21 +0200
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Eric Dumazet <erdnetdev@...il.com>
Cc:	David Miller <davem@...emloft.net>, maxk@....qualcomm.com,
	netdev@...r.kernel.org, dwmw2@...radead.org
Subject: Re: openconnect triggers soft lockup in __skb_get_rxhash

On Sun, Dec 16, 2012 at 08:46:29PM -0800, Eric Dumazet wrote:
> On Mon, 2012-12-17 at 03:46 +0200, Kirill A. Shutemov wrote:
> > On Sun, Dec 16, 2012 at 05:22:14PM -0800, David Miller wrote:
> > > 
> > > Already fixed in Linus's tree by:
> > > 
> > > From 499744209b2cbca66c42119226e5470da3bb7040 Mon Sep 17 00:00:00 2001
> > 
> > No, it's not. I use up-to-date (2a74dbb) Linus tree with the patch in and
> > still see the issue.
> > 
> 
> Coud you try the following one liner ?

Works for me. So far no problems.

Reported-and-tested-by: Kirill A. Shutemov <kirill@...temov.name>

> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 255a9f5..173acf5 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -1199,6 +1199,7 @@ static ssize_t tun_get_user(struct tun_struct *tun, struct tun_file *tfile,
>  		skb_shinfo(skb)->tx_flags |= SKBTX_DEV_ZEROCOPY;
>  	}
>  
> +	skb_reset_network_header(skb);
>  	rxhash = skb_get_rxhash(skb);
>  	netif_rx_ni(skb);
>  
> 
> 

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html