netdev - Re: [PATCH] tuntap: reset network header before calling skb_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121217.123311.1003355345453159139.davem@davemloft.net>
Date:	Mon, 17 Dec 2012 12:33:11 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	danborkmann@...earbox.net, kirill@...temov.name,
	maxk@....qualcomm.com, netdev@...r.kernel.org, dwmw2@...radead.org
Subject: Re: [PATCH] tuntap: reset network header before calling
 skb_get_rxhash()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 17 Dec 2012 06:39:20 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Commit 499744209b2c (tuntap: dont use skb after netif_rx_ni(skb))
> introduced another bug.
> 
> skb_get_rxhash() needs to access the network header, and it was
> set for us in netif_rx_ni().
> 
> We need to reset network header or else skb_flow_dissect() behavior
> is out of control.
> 
> Reported-and-tested-by: Kirill A. Shutemov <kirill@...temov.name>
> Tested-by: Daniel Borkmann <daniel.borkmann@....ee.ethz.ch>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, hopefully we've really resolved this fully now :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html