netdev - Re: [PATCH V2 01/12] bridge: Add vlan filtering infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50D0DF86.9070801@redhat.com>
Date:	Tue, 18 Dec 2012 16:26:30 -0500
From:	Vlad Yasevich <vyasevic@...hat.com>
To:	Eric Dumazet <erdnetdev@...il.com>
CC:	netdev@...r.kernel.org, shemminger@...tta.com, davem@...emloft.net,
	or.gerlitz@...il.com, jhs@...atatu.com, mst@...hat.com
Subject: Re: [PATCH V2 01/12] bridge: Add vlan filtering infrastructure

On 12/18/2012 04:13 PM, Eric Dumazet wrote:
> On Tue, 2012-12-18 at 14:00 -0500, Vlad Yasevich wrote:
>
>> +static void br_vlan_destroy(struct net_bridge_vlan *vlan)
>> +{
>> +	if (!bitmap_empty(vlan->port_bitmap, PORT_BITMAP_LEN)) {
>> +		pr_err("Attempt to delete a VLAN %d from the bridge with "
>> +		       "non-empty port bitmap (%p)\n", vlan->vid, vlan);
>> +		BUG();
>> +	}
>> +
>> +	hlist_del_rcu(&vlan->hlist);
>> +	synchronize_net();
>> +	kfree_rcu(vlan, rcu);
>> +}
>
> Not clear why you both use synchronize_net() and kfree_rcu()
>


I think this was a left-over from old code.  I think this was
originally here to mimic del_nbp behavior, but I don't think
it's really needed as kfree_rcu should wait until all current
rcu section have completed.

-vlad
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html