netdev - Re: [PATCH 04/11] bridge: Cache vlan in the cb for faster egress lookup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121218090448.69c21daa@nehalam.linuxnetplumber.net>
Date:	Tue, 18 Dec 2012 09:04:48 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, mst@...hat.com,
	john.r.fastabend@...el.com
Subject: Re: [PATCH 04/11] bridge: Cache vlan in the cb for faster egress
 lookup.

On Wed, 12 Dec 2012 15:01:10 -0500
Vlad Yasevich <vyasevic@...hat.com> wrote:

> On input, cache the pointer to the bridge vlan info, so that
> on egress, we have can simply look at the port bitmap instead
> of traversing a vlan list.
> 
> Signed-off-by: Vlad Yasevich <vyasevic@...hat.com>

This isn't going to be safe. Once packet is passed up, the cb[]
can get overwritten by other things.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html