lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20121224.184326.555443730875272088.davem@davemloft.net>
Date:	Mon, 24 Dec 2012 18:43:26 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	erdnetdev@...il.com
Cc:	xiyou.wangcong@...il.com, netdev@...r.kernel.org,
	sedat.dilek@...il.com, edumazet@...gle.com, ja@....bg
Subject: Re: [Patch v2] arp: fix a regression in arp_solicit()

From: Eric Dumazet <erdnetdev@...il.com>
Date: Mon, 24 Dec 2012 08:41:14 -0800

> On Mon, 2012-12-24 at 09:23 +0800, Cong Wang wrote:
>> From: Cong Wang <xiyou.wangcong@...il.com>
>> 
>> Sedat reported the following commit caused a regression:
>> 
>> commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1
>> Author: Eric Dumazet <edumazet@...gle.com>
>> Date:   Fri Dec 21 07:32:10 2012 +0000
>> 
>>     ipv4: arp: fix a lockdep splat in arp_solicit
>> 
>> This is due to the 6th parameter of arp_send() needs to be NULL
>> for the broadcast case, the above commit changed it to an all-zero
>> array by mistake.
>> 
>> Reported-by: Sedat Dilek <sedat.dilek@...il.com>
>> Tested-by: Sedat Dilek <sedat.dilek@...il.com>
>> Cc: Sedat Dilek <sedat.dilek@...il.com>
>> Cc: Eric Dumazet <edumazet@...gle.com>
>> Cc: David S. Miller <davem@...emloft.net>
>> Cc: Julian Anastasov <ja@....bg>
>> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
>> 
>> ---
> 
> Oops, thanks for fixing this.
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ