lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <50DB68E8.2010506@lwfinger.net> Date: Wed, 26 Dec 2012 15:15:20 -0600 From: Larry Finger <Larry.Finger@...inger.net> To: Jesper Juhl <jj@...osbits.net> CC: linux-kernel@...r.kernel.org, wlanfae <wlanfae@...ltek.com>, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, "John W. Linville" <linville@...driver.com>, Chaoming Li <chaoming_li@...lsil.com.cn> Subject: Re: [PATCH] rtlwifi: Don't leak on error in _rtl_usb_receive() On 12/26/2012 02:51 PM, Jesper Juhl wrote: > We fail to release 'urb' if '_rtl_prep_rx_urb()' fails in > _rtl_usb_receive(). > This patch should take care of the leak. > > Signed-off-by: Jesper Juhl <jj@...osbits.net> > --- > drivers/net/wireless/rtlwifi/usb.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > note: compile tested only. This looks correct to me. I have never seen that RT_TRACE() fire, thus such an error must be uncommon, at least on my system. Acked-by: Larry Finger <Larry.Finger@...inger.net> Thanks, Larry > > diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c > index 29f0969..75c29e6 100644 > --- a/drivers/net/wireless/rtlwifi/usb.c > +++ b/drivers/net/wireless/rtlwifi/usb.c > @@ -640,6 +640,7 @@ static int _rtl_usb_receive(struct ieee80211_hw *hw) > RT_TRACE(rtlpriv, COMP_USB, DBG_EMERG, > "Failed to prep_rx_urb!!\n"); > err = PTR_ERR(skb); > + usb_free_urb(urb); > goto err_out; > } > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists