lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1356563631.30414.3.camel@edumazet-glaptop> Date: Wed, 26 Dec 2012 15:13:51 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Larry Finger <Larry.Finger@...inger.net> Cc: linville@...driver.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH V3.8 5/5] rtlwifi: rtl8723ae: Fix warning for unchecked pci_map_single() call On Wed, 2012-12-26 at 16:08 -0600, Larry Finger wrote: > Kernel 3.8 implements checking of all DMA mapping calls and issues > a WARNING for the first it finds that is not checked. > > Signed-off-by: Larry Finger <Larry.Finger@...inger.net> > --- > drivers/net/wireless/rtlwifi/rtl8723ae/trx.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/net/wireless/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/rtlwifi/rtl8723ae/trx.c > index 87331d8..7ddd517 100644 > --- a/drivers/net/wireless/rtlwifi/rtl8723ae/trx.c > +++ b/drivers/net/wireless/rtlwifi/rtl8723ae/trx.c > @@ -387,6 +387,12 @@ void rtl8723ae_tx_fill_desc(struct ieee80211_hw *hw, > PCI_DMA_TODEVICE); > u8 bw_40 = 0; > > + if (pci_dma_mapping_error(rtlpci->pdev, mapping)) { > + RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, > + "DMA mapping error"); > + return; > + } > + CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE); > if (mac->opmode == NL80211_IFTYPE_STATION) { > bw_40 = mac->bw_40; > } else if (mac->opmode == NL80211_IFTYPE_AP || > @@ -542,6 +548,12 @@ void rtl8723ae_tx_fill_cmddesc(struct ieee80211_hw *hw, > PCI_DMA_TODEVICE); > __le16 fc = hdr->frame_control; > > + if (pci_dma_mapping_error(rtlpci->pdev, mapping)) { > + RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, > + "DMA mapping error"); > + return; > + } > + CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE); > CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE); > > if (firstseg) This seems wrong... CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE) doesnt need to be done twice, does it ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists