netdev - Re: [PATCH 1/2] ipv4/ip_gre: set transport header correctly to gre header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121226.152025.1719078076502235330.davem@davemloft.net>
Date:	Wed, 26 Dec 2012 15:20:25 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yamahata@...inux.co.jp
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] ipv4/ip_gre: set transport header correctly to gre
 header

From: Isaku Yamahata <yamahata@...inux.co.jp>
Date: Tue, 25 Dec 2012 11:51:03 +0900

> ipgre_tunnel_xmit() incorrectly sets transport header to inner payload
> instead of GRE header. It seems copy-and-pasted from ipip.c.
> So set transport header to gre header.
> (In ipip case the transport header is the inner ip header, so that's
> correct.)
> 
> Found by inspection. In practice the incorrect transport header
> doesn't matter because the skb usually is sent to another net_device
> or socket, so the transport header isn't referenced.
> 
> Signed-off-by: Isaku Yamahata <yamahata@...inux.co.jp>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html