netdev - Re: [PATCH] bgmac: driver for GBit MAC core on BCMA bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rydhYcBZnRpz2PD5S=UfjQJ5xqkY=_+Y9BeOt-ENQqc3w@mail.gmail.com>
Date:	Thu, 27 Dec 2012 01:45:24 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] bgmac: driver for GBit MAC core on BCMA bus

Thanks for your comments, I'll improve the driver/patch.

2012/12/27 Francois Romieu <romieu@...zoreil.com>:
>> +     struct device *dma_dev = bgmac->core->dma_dev;
>> +     struct bgmac_dma_desc *dma_desc;
>> +     struct bgmac_slot_info *slot;
>> +     struct sk_buff *skb, *new_skb;
>> +     struct bgmac_rx_header *rx;
>> +     u32 end_slot;
>> +     u16 len, flags;
>> +     int handled = 0;
>
> The scope of several variables can be reduced as well.

I'm not 100% if I understand... Do you mean I should declare variables
inside "while" loop when possible? I couldn't find suggestions about
anywhere in Documentation, so please give me an extra work of
explanation :)

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html