netdev - Re: [Patch RFC] ndisc: Fix skb allocation size for link layer options.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50DF1C59.1040902@gmail.com>
Date:	Sat, 29 Dec 2012 17:37:45 +0100
From:	Stephan Gatzka <stephan.gatzka@...il.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
CC:	netdev@...r.kernel.org
Subject: Re: [Patch RFC] ndisc: Fix skb allocation size for link layer options.

> 
> Disagree.  NDISC_OPT_SPACE() takes care size of nd option header.
Agree. I misunderstood this, my fault.

Maybe it's better to write:

#define NDISC_OPT_SPACE(len) (((len)+sizeof(nd_opt_hdr)+7)&~7)

Regards,

Stephan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html