lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <A40E06F5-7F2F-454F-9C2D-A023CCB30D43@resnulli.us> Date: Sun, 30 Dec 2012 14:06:50 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Michał Mirosław <mirqus@...il.com> Cc: netdev <netdev@...r.kernel.org>, Flavio Leitner <fbl@...hat.com> Subject: Re: [PATCH net-next] team: implement carrier change 30. 12. 2012 v 14:03, Michał Mirosław <mirqus@...il.com>: > 2012/12/30 Flavio Leitner <fbl@...hat.com>: >> The user space teamd daemon may need to control the >> master's carrier state depending on the selected mode. > [...] >> +static int team_change_carrier(struct net_device *dev, bool new_carrier) >> +{ >> + if (new_carrier) >> + netif_carrier_on(dev); >> + else >> + netif_carrier_off(dev); >> + return 0; >> +} >> + > [...] >> + .ndo_change_carrier = team_change_carrier, > > I wonder what else you might put in the .ndo_change_carrier > implementation? It's already the same for dummy device and tunnels > would get more copies. Maybe it would be enough to allocate a bit in > netdev->priv_flags and use that in dev_change_carrier() instead? > Flavio has a patch adding some more code here prepared already. Will be posted soon. > Best Regards, > Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists