lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121230014403.GA2077@obelix.rh> Date: Sat, 29 Dec 2012 23:44:03 -0200 From: Flavio Leitner <fbl@...hat.com> To: Stephen Hemminger <shemminger@...tta.com> Cc: netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us> Subject: Re: [PATCH net-next] team: add ethtool support On Sat, Dec 29, 2012 at 05:29:45PM -0800, Stephen Hemminger wrote: > On Sat, 29 Dec 2012 23:19:26 -0200 > Flavio Leitner <fbl@...hat.com> wrote: > > > This patch adds few ethtool operations to team driver. > > > > Signed-off-by: Flavio Leitner <fbl@...hat.com> > > What is the motivation for this? Is there an application that depends > on ethtool (versus netlink, or /proc)? Speaking as a support engineer, it's a lot easier to grab ethtool -S and see everything than grab two or more outputs. > Sorry, I see no point in providing ethtool statistics for generic data that is already > reported by existing netlink and other infrastructure. The purpose of ethtool > statistics is to report device specific that is not available through the normal > generic statistics. Right, but those statistics can be device specific as well. The tg3 and bnx2, for instance, do the same reporting [rx|tx]_bytes|octets. I see no harm, and it is helpful. -- fbl -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists