| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20130102.184728.810047795466238734.davem@davemloft.net> Date: Wed, 02 Jan 2013 18:47:28 -0800 (PST) From: David Miller <davem@...emloft.net> To: ariele@...adcom.com Cc: netdev@...r.kernel.org, eilong@...adcom.com Subject: Re: [PATCH net-next] bnx2x: Fix compilation when CONFIG_PCI_IOV is not defined From: "Ariel Elior" <ariele@...adcom.com> Date: Wed, 2 Jan 2013 15:36:25 +0200 > This patch ifdefs out the use of PCI_IOV_RESOURCES which exists in the > kernel only when CONFIG_PCI_IOV is defined. There is no point in doing > the same for the invocation of SRIOV functionality in the driver as it > will be immediately failed by a kernel which was thus compiled. > > Signed-off-by: Ariel Elior <ariele@...adcom.com> This fixes the build but this is a very disappointing patch. None of your SR-IOV support can possibly work if CONFIG_PCI_IOV is not set. Look at how the SFC driver has a special Kconfig option and elides all of it's SR-IOV code when that Kconfig option is not set. That kind of Kconfig option is where you express the CONFIG_PCI_IOV dependency, rather than in a hackish way with ifdefs as a knee-jerk response to a build failure reports. I'm not applying this patch, segregate your driver properly and use Kconfig dependencies to elide the building of all of the SR-IOV support code in this driver. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists