netdev - Re: clk dereference in drivers/net/ethernet/ti/cpts.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130103140000.GA9656@localhost.localdomain>
Date:	Thu, 3 Jan 2013 15:00:00 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	davem@...emloft.net, tony@...mide.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: clk dereference in drivers/net/ethernet/ti/cpts.c

On Thu, Jan 03, 2013 at 11:20:52AM +0100, Julia Lawall wrote:
> There has been a discussion recently about how the result of get_clk
> should be an opaque handle, not a value that can be dereferenced:
> 
> https://lkml.org/lkml/2012/12/20/105
> 
> There is such a dereference in drivers/net/ethernet/ti/cpts.c, in the
> function cpts_clk_init:
> 
> cpts->freq = cpts->refclk->recalc(cpts->refclk);
> 
> It was not obvious to me, however, what API function should be used
> instead, so I am just reporting the (potential) problem.

This issue has been fixed in v3.8-rc2.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html