netdev - Re: [PATCH V2] bgmac: driver for GBit MAC core on BCMA bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACna6rzOm3+NihpzMdsQUFfLXy+gZmhtatzjU3+EiujOvndW-A@mail.gmail.com>
Date:	Thu, 3 Jan 2013 18:38:11 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Francois Romieu <romieu@...zoreil.com>
Subject: Re: [PATCH V2] bgmac: driver for GBit MAC core on BCMA bus

2013/1/3 Joe Perches <joe@...ches.com>:
> On Thu, 2013-01-03 at 17:56 +0100, Rafał Miłecki wrote:
>> BCMA is a Broadcom specific bus with devices AKA cores. All recent BCMA
>> based SoCs have gigabit ethernet provided by the GBit MAC core. This
>> patch adds driver for such a cores registering itself as a netdev. It
>> has been tested on a BCM4706 and BCM4718 chipsets.
>
> Just some style trivia if you want to clean it up later.
>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> []
>> +             bgmac_err(bgmac, "Timeout suspending DMA TX ring 0x%X (BGMAC_DMA_TX_STAT: 0x%08X)\n",
>> +                       ring->mmio_base, val);
>
> It'd be nicer if you always used this wrapping style.

My bad, sorry! Waiting for Francois comments before submitting next version.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html