netdev - Re: [PATCH] netfilter: xt_recent: avoid high order page allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130104192316.GA17714@1984>
Date:	Fri, 4 Jan 2013 20:23:16 +0100
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org,
	Miroslav Kratochvil <exa.exa@...il.com>,
	h.reindl@...lounge.net, Dave Jones <davej@...hat.com>
Subject: Re: [PATCH] netfilter: xt_recent: avoid high order page allocations

On Fri, Jan 04, 2013 at 12:18:39AM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> xt_recent can try high order page allocations and this can fail.
> 
> iptables: page allocation failure: order:9, mode:0xc0d0
> 
> It also wastes about half the allocated space because of kmalloc()
> power-of-two roundups and struct recent_table layout.
> 
> Use vmalloc() instead to save space and be less prone to allocation
> errors when memory is fragmented.

Applied, thanks Eric!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html