netdev - Re: [PATCH] ipv4: fix NULL checking in devinet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1357427402.1678.4738.camel@edumazet-glaptop>
Date:	Sat, 05 Jan 2013 15:10:02 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Xi Wang <xi.wang@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: fix NULL checking in devinet_ioctl()

On Sat, 2013-01-05 at 16:19 -0500, Xi Wang wrote:
> The NULL pointer check `!ifa' should come before its first use.
> 
> Signed-off-by: Xi Wang <xi.wang@...il.com>
> ---
>  net/ipv4/devinet.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> index cc06a47..a8e4f26 100644
> --- a/net/ipv4/devinet.c
> +++ b/net/ipv4/devinet.c
> @@ -823,9 +823,9 @@ int devinet_ioctl(struct net *net, unsigned int cmd, void __user *arg)
>  		if (!ifa) {
>  			ret = -ENOBUFS;
>  			ifa = inet_alloc_ifa();
> -			INIT_HLIST_NODE(&ifa->hash);
>  			if (!ifa)
>  				break;
> +			INIT_HLIST_NODE(&ifa->hash);
>  			if (colon)
>  				memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ);
>  			else

Acked-by: Eric Dumazet <edumazet@...gle.com>

Bug origin : commit fd23c3b31107e2fc483301ee923d8a1db14e53f4
(ipv4: Add hash table of interface addresses) 

in linux-2.6.39

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html