[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130106.194917.2049529796787288137.davem@davemloft.net>
Date: Sun, 06 Jan 2013 19:49:17 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: amwang@...hat.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/3] netpoll: add IPv6 support
From: Cong Wang <amwang@...hat.com>
Date: Mon, 07 Jan 2013 10:58:05 +0800
> On Thu, 2013-01-03 at 19:20 -0800, David Miller wrote:
>> From: Cong Wang <amwang@...hat.com>
>> Date: Fri, 4 Jan 2013 11:14:30 +0800
>>
>> > (Resend with a cover letter)
>> >
>> > v3: fix CONFIG_IPV6=m case
>> >
>> > v2: use bool for ipv6 flag
>> > fix !CONFIG_IPV6 case
>> >
>> > This patchset implements netpoll over IPv6.
>>
>> Thanks for submitting this properly.
>>
>> But disallowing ipv6 netpoll support when IPV6=m is an unacceptable
>> limitation, compiling IPV6 as a module is common and in fact
>> recommended.
>>
>> We've solved problems like this before, by putting the needed ipv6
>> routines into a seperate library that is built statically into the
>> kernel when necessary.
>>
>> You should use a similar approach here.
>
> Hmm, here we need ndisc_parse_options() and udp6_csum_init(). Not sure
> if both can be inlined?
I didn't say "inline", read my email again.
We put such routines into a static library of ipv6 routines
that gets statically built into vmlinux even if ipv6 is
modular.
I'm not explaining this agin.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists