netdev - Re: [patch net-next V2] ethtool: fix drvinfo strings set in drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130106.210655.1262628911724067629.davem@davemloft.net>
Date:	Sun, 06 Jan 2013 21:06:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, edumazet@...gle.com,
	bhutchings@...arflare.com, shemminger@...tta.com, fbl@...hat.com,
	sathya.perla@...lex.com, subbu.seetharaman@...lex.com,
	ajit.khaparde@...lex.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, ursula.braun@...ibm.com,
	blaschka@...ux.vnet.ibm.com, linux390@...ibm.com
Subject: Re: [patch net-next V2] ethtool: fix drvinfo strings set in drivers

From: Jiri Pirko <jiri@...nulli.us>
Date: Sun,  6 Jan 2013 11:44:26 +0100

> Use strlcpy where possible to ensure the string is \0 terminated.
> Use always sizeof(string) instead of 32, ETHTOOL_BUSINFO_LEN
> and custom defines.
> Use snprintf instead of sprint.
> Remove unnecessary inits of ->fw_version
> Remove unnecessary inits of drvinfo struct.
> 
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html