netdev - re: bnx2x: Prepare device and initialize VF database

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130107081836.GA5023@elgon.mountain>
Date:	Mon, 7 Jan 2013 11:18:37 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	ariele@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: re: bnx2x: Prepare device and initialize VF database

Hello Ariel Elior,

The patch b56e9670ffa4: "bnx2x: Prepare device and initialize VF
database" from Jan 1, 2013, leads to the following warning:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c:1346
bnx2x_pretend_func()
	 warn: should this be '>= E1H_FUNC_MAX'

drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
  1342  int bnx2x_pretend_func(struct bnx2x *bp, u16 pretend_func_val)
  1343  {
  1344          u32 pretend_reg;
  1345  
  1346          if (CHIP_IS_E1H(bp) && pretend_func_val > E1H_FUNC_MAX)
  1347                  return -1;
  1348  

This is static checker test has too many false positives so I haven't
released it.  Basically, every other place that uses E1H_FUNC_MAX
assumes we start counting from zero except this one.  I don't know the
code enough to say if it's a problem or intended.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html