netdev - Re: [RFC PATCH v2 net-next 0/2] Remove NETIF_F_NETNS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 07 Jan 2013 01:25:25 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Rami Rosen <ramirose@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, shemminger@...tta.com
Subject: Re: [RFC PATCH v2 net-next 0/2] Remove NETIF_F_NETNS_LOCAL from software devices.

Rami Rosen <ramirose@...il.com> writes:

> When NETIF_F_NETNS_LOCAL feature is set in some network device,  
> we do not allow this device to be moved from one network namespace 
> to another (see dev_change_net_namespace()). Vlan device is not considered 
> a local device and does not have the NETIF_F_NETNS_LOCAL feature. There is no 
> reason that software devices like ppp and bridge will set the
> NETIF_F_NETNS_LOCAL feature. This patchset removes NETIF_F_NETNS_LOCAL
> from ppp and bridge devices.

After you saw the case for vxlan I am disappointed you respun this
patchset without asking the question: Could other devices suffer
from the same class of problem.

It didn't take me more than a few minutes of looking to see that the
bridge and the ppp network device have the same class of issue as
vxlan.

> * Changes from v1
> 	Do not remove NETIF_F_NETNS_LOCAL from vxlan devices. Moving vxlan device 
> 	to a different namesapce does not move the state of the UDP socket related 
> 	to this vxlan device (Following Stephen Hemminger comment).
> 	
> Rami Rosen (2):
>   [RFC PATCH v2 net-next 1/3] ppp: remove NETIF_F_NETNS_LOCAL from ppp
>     device features.
>   [RFC PATCH v2 net-next 2/3] bridge: remove NETIF_F_NETNS_LOCAL from
>     bridge device features.
>
>  drivers/net/ppp/ppp_generic.c | 1 -
>  net/bridge/br_device.c        | 2 +-
>  2 files changed, 1 insertion(+), 2 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html