netdev - Re: [patch] bnx2x: NULL dereference on error in debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130108.143058.802178708339067441.davem@davemloft.net>
Date:	Tue, 08 Jan 2013 14:30:58 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ariele@...adcom.com
Cc:	dan.carpenter@...cle.com, eilong@...adcom.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] bnx2x: NULL dereference on error in debug code

From: "Ariel Elior" <ariele@...adcom.com>
Date: Tue, 8 Jan 2013 14:50:50 +0000

>> -----Original Message-----
>> From: netdev-owner@...r.kernel.org [mailto:netdev-
>> owner@...r.kernel.org] On Behalf Of Dan Carpenter
>> Sent: Tuesday, January 08, 2013 3:42 PM
>> To: Eilon Greenstein
>> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
>> janitors@...r.kernel.org
>> Subject: [patch] bnx2x: NULL dereference on error in debug code
>> 
>> "vfop" is NULL here.  I've changed the debugging to not use it.
>> 
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>> ---
>> Only needed in linux-next.
>> 
>> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> index 71fcef0..3eef972 100644
>> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
>> @@ -463,8 +463,7 @@ static int bnx2x_vfop_qdtor_cmd(struct bnx2x *bp,
>>  		return bnx2x_vfop_transition(bp, vf, bnx2x_vfop_qdtor,
>>  					     cmd->block);
>>  	}
>> -	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop. rc %d\n",
>> -	   vf->abs_vfid, vfop->rc);
>> +	DP(BNX2X_MSG_IOV, "VF[%d] failed to add a vfop.\n", vf->abs_vfid);
>>  	return -ENOMEM;
>>  }
>> 
> Right you are. Ack.

This is not the correct way to ack a patch, this is:

Acked-by: Ariel Elior <ariele@...adcom.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html