netdev - Re: [E1000-devel] [PATCH net-next] igbvf: fix setting addr_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50EDAFC6.3070700@kpanic.de>
Date:	Wed, 09 Jan 2013 18:58:30 +0100
From:	Stefan Assmann <sassmann@...nic.de>
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: Re: [E1000-devel] [PATCH net-next] igbvf: fix setting addr_assign_type
 if PF is up

On 09.01.2013 18:09, Williams, Mitch A wrote:
>> -----Original Message-----
>> From: Stefan Assmann [mailto:sassmann@...nic.de]
>> Sent: Wednesday, January 09, 2013 1:59 AM
>> To: netdev@...r.kernel.org
>> Cc: e1000-devel@...ts.sourceforge.net; sassmann@...nic.de
>> Subject: [E1000-devel] [PATCH net-next] igbvf: fix setting
>> addr_assign_type if PF is up
>>
>> When the PF is up and igbvf is loaded the MAC address is not generated
>> using eth_hw_addr_random(). This results in addr_assign_type not to be
>> set.
>> Make sure it gets set.
>>
> 
> NAK - In this case, the address may or may not be random. The user may
> have (and should have!) explicitly set this address from the host to
> ensure that the VF device receives the same address each time it boots.

Maybe you can give me some advice on this then. Why is there different
behaviour depending on the PF being up or down? The problem I'm facing
is that if the user did not set a MAC address for the VF manually and
the PF is up during igbvf_probe it will not be labelled as random
although it is.
What about checking IGB_VF_FLAG_PF_SET_MAC and only set NET_ADDR_RANDOM
if the flag is cleared?

  Stefan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html