netdev - Re: [Patch] net: prevent setting ttl=0 via IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130108.175755.500141755302198039.davem@davemloft.net>
Date:	Tue, 08 Jan 2013 17:57:55 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, padalia.nitin@...il.com,
	eric.dumazet@...il.com
Subject: Re: [Patch] net: prevent setting ttl=0 via IP_TTL

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue,  8 Jan 2013 15:17:00 +0800

> From: Cong Wang <xiyou.wangcong@...il.com>
> 
> A regression is introduced by the following commit:
> 
> 	commit 4d52cfbef6266092d535237ba5a4b981458ab171
> 	Author: Eric Dumazet <eric.dumazet@...il.com>
> 	Date:   Tue Jun 2 00:42:16 2009 -0700
> 
> 	    net: ipv4/ip_sockglue.c cleanups
> 	    
> 	    Pure cleanups
> 
> but it is not a pure cleanup...
> 
> 	-               if (val != -1 && (val < 1 || val>255))
> 	+               if (val != -1 && (val < 0 || val > 255))
> 
> Since there is no reason provided to allow ttl=0, change it back.
> 
> Reported-by: nitin padalia <padalia.nitin@...il.com>
> Cc: nitin padalia <padalia.nitin@...il.com>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Cc: David S. Miller <davem@...emloft.net>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html