netdev - Re: [PATCH] tun: avoid owner checks on IFF_ATTACH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130110.143835.2008690798301758570.davem@davemloft.net>
Date:	Thu, 10 Jan 2013 14:38:35 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	stefanha@...hat.com
Cc:	mst@...hat.com, jasowang@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tun: avoid owner checks on IFF_ATTACH_QUEUE

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Thu, 10 Jan 2013 12:55:03 +0100

> On Thu, Jan 10, 2013 at 01:31:08PM +0200, Michael S. Tsirkin wrote:
>> At the moment, we check owner when we enable queue in tun.
>> This seems redundant and will break some valid uses
>> where fd is passed around: I think TUNSETOWNER is there
>> to prevent others from attaching to a persistent device not
>> owned by them. Here the fd is already attached,
>> enabling/disabling queue is more like read/write.
>> 
>> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>> 
>> ---
>> 
>> Note: this is unrelated to Stefan's bugfix.
> 
> This should go into 3.8-rc.
> 
> Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html