netdev - Re: [PATCH v2 3/3] net: stmmac: add gmac autonego set for ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130110.155759.127269416182567301.davem@davemloft.net>
Date:	Thu, 10 Jan 2013 15:57:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bh74.an@...sung.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	peppe.cavallaro@...com, jeffrey.t.kirsher@...el.com,
	kgene.kim@...sung.com
Subject: Re: [PATCH v2 3/3] net: stmmac: add gmac autonego set for ethtool
 support

From: Byungho An <bh74.an@...sung.com>
Date: Thu, 10 Jan 2013 15:54:24 -0800

> @@ -348,6 +349,10 @@ stmmac_set_pauseparam(struct net_device *netdev,
>  
>  	if (phy->autoneg) {
>  		if (netif_running(netdev))
> +			if((interface == PHY_INTERFACE_MODE_SGMII) ||
> +			   (interface == PHY_INTERFACE_MODE_TBI) ||
> +			   (interface == PHY_INTERFACE_MODE_RTBI)) 
> +				priv->hw->mac->set_autoneg(priv->ioaddr);

This is still not properly formatted.

You also didn't submit this properly.  Never use email thread replies
to submit new versions of patches.

Always use fresh, new, mailing list postings to submit new versions
of patches.

Also, when one patch has to change in a series, you must reubmit
the entire set of patches even if some of them have no changes
at all.  I do not see patch #2 here at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html