netdev - Re: [PATCH net] qlge: remove NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130111.155919.809159136231664892.davem@davemloft.net>
Date:	Fri, 11 Jan 2013 15:59:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jitendra.kalsaria@...gic.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org, ron.mercer@...gic.com,
	Linux-Driver@...gic.com
Subject: Re: [PATCH net] qlge: remove NETIF_F_TSO6 flag

From: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Date: Fri, 11 Jan 2013 21:48:52 +0000

> 
>>From: Cong Wang [mailto:amwang@...hat.com] 
>>Sent: Friday, January 11, 2013 12:53 AM
>>To: netdev
>>Cc: Jitendra Kalsaria; Ron Mercer; Dept-Eng Linux Driver; David Miller; Cong Wang
>>Subject: [PATCH net] qlge: remove NETIF_F_TSO6 flag
>>
>>It is werid that qlge driver supports NETIF_F_TSO6 but
>>not NETIF_F_IPV6_CSUM. This also causes some kernel warning [1]
>>when VLAN device setups on a qlge interface.
>>
>>I think the qlge hardware doesn't support NETIF_F_IPV6_CSUM,
>>so we have to just remove the NETIF_F_TSO6 flag.
>>
>>After this patch, the TCP/IPv6 traffic becomes normal again,
>>no kernel warnings any more.
>>
>>NOTE: I only tested it on 2.6.32 kernel, even if the upstream
>>kernel could fix this automatically (it is hard to track NETIF*
>>flags), removing it is also safe.
>>
>>1. https://bugzilla.redhat.com/show_bug.cgi?id=891839
>>
>>Cc: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
>>Cc: Ron Mercer <ron.mercer@...gic.com>
>>Cc: linux-driver@...gic.com
>>Cc: David S. Miller <davem@...emloft.net>
>>Signed-off-by: Cong Wang <amwang@...hat.com>
> 
> Thanks!
> Acked-by: Jitendra Kalsaria <jitendra.kalsaria@...gic.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html