netdev - Re: [RFC PATCH] net: phy: remove flags argument from phy_{attach,connect,connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130111.194729.1404456884791637120.davem@davemloft.net>
Date:	Fri, 11 Jan 2013 19:47:29 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	florian@...nwrt.org
Cc:	netdev@...r.kernel.org, konszert@...vell.com, afleming@...il.com
Subject: Re: [RFC PATCH] net: phy: remove flags argument from
 phy_{attach,connect,connect_direct}

From: Florian Fainelli <florian@...nwrt.org>
Date: Fri, 11 Jan 2013 12:31:47 +0100

> The flags argument of the phy_{attach,connect,connect_direct} functions
> is used to assign a struct phy_device dev_flags with the value passed.
> All callers but the tg3 driver pass the flag 0, which results in the
> underlying PHY drivers in drivers/net/phy/ not being able to actually
> use any of the flags they would check in dev_flags. This patch gets rid of
> the flags argument, and passes phydev->dev_flags to the internal PHY
> library call phy_attach_direct() such that drivers which actually modify
> a phy device dev_flags get the value preserved for use by the underly
> phy driver.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

This change is fine, except for this part:

> diff --git a/include/linux/version.h b/include/linux/version.h
> new file mode 100644
> index 0000000..0c8c321
> --- /dev/null
> +++ b/include/linux/version.h
> @@ -0,0 +1,2 @@
> +#define LINUX_VERSION_CODE 197120
> +#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html