netdev - Re: [PATCH 1/3] ssb: add missing method ssb_gige_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130113104729.37b9fa03@milhouse>
Date:	Sun, 13 Jan 2013 10:47:29 +0100
From:	Michael Büsch <m@...s.ch>
To:	David Miller <davem@...emloft.net>
Cc:	hauke@...ke-m.de, mcarlson@...adcom.com, mchan@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] ssb: add missing method ssb_gige_get_macaddr

On Sat, 12 Jan 2013 15:32:11 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Hauke Mehrtens <hauke@...ke-m.de>
> Date: Sat, 12 Jan 2013 21:01:43 +0100
> 
> > When CONFIG_SSB_DRIVER_GIGE is not set the header does not provide the
> > needed method.
> > 
> > Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> 
> This isn't right.
> 
> You can't implement this function in a way that the caller cannot
> determine that it didn't actually do anything.
> 
> You either have to protect calls with ifdefs or make this routine
> return an error indication, in response to which the caller can
> set a random ethernet address or take some other corrective action.

tg3 uses is_valid_ether_addr() afterwards anyway. An error code return value
could be added, but it didn't seem necessary.

-- 
Greetings, Michael.

PGP: 908D8B0E

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)