netdev - Re: [PATCH] tcp: fix a panic on UP machines in reqsk_fastopen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130114.181030.1911364060960863615.davem@davemloft.net>
Date:	Mon, 14 Jan 2013 18:10:30 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hkchu@...gle.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, ketkulka@...il.com,
	ycheng@...gle.com
Subject: Re: [PATCH] tcp: fix a panic on UP machines in
 reqsk_fastopen_remove

From: Jerry Chu <hkchu@...gle.com>
Date: Mon, 14 Jan 2013 00:26:26 -0800

> On Sun, Jan 13, 2013 at 8:21 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> From: Eric Dumazet <edumazet@...gle.com>
>>
>> spin_is_locked() on a non !SMP build is kind of useless.
>>
>> BUG_ON(!spin_is_locked(xx)) is guaranteed to crash.
>>
>> Just remove this check in reqsk_fastopen_remove() as
>> the callers do hold the socket lock.
>>
>> Reported-by: Ketan Kulkarni <ketkulka@...il.com>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
 ...
> Thanks, Eric. (I thought the assertion would be transparent to UP...)
> 
> Acked-by: H.K. Jerry Chu <hkchu@...gle.com>
> 

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html