netdev - Re: [PATCH net-next 09/10] bnx2x: Added FW GRO bridging support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1358189075.8744.3320.camel@edumazet-glaptop>
Date:	Mon, 14 Jan 2013 10:44:35 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Yuval Mintz <yuvalmin@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, eilong@...adcom.com,
	ariele@...adcom.com
Subject: Re: [PATCH net-next 09/10] bnx2x: Added FW GRO bridging support

On Mon, 2013-01-14 at 09:22 -0800, Eric Dumazet wrote:

> This looks weird to me. This should be called by GRO stack only.
> 
> What is the value of gso_segs ?
> 
> 

The reason I am pointing this out is the recent change in commit
1def9238d4aa2146924994aa4b7dc861f03b9362
(net_sched: more precise pkt_len computation)

bnx2x not setting gso_segs means that qdisc accounting on ingress is
completely wrong.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html