netdev - Re: [PATCH] r8169: remove unneeded dirty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130116.162500.1216966272191204366.davem@davemloft.net>
Date:	Wed, 16 Jan 2013 16:25:00 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	timo.teras@....fi
Cc:	romieu@...zoreil.com, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: remove unneeded dirty_rx index

From: Timo Teräs <timo.teras@....fi>
Date: Wed, 16 Jan 2013 09:01:24 +0200

> @@ -6035,10 +6034,8 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
>  	unsigned int count;
>  
>  	cur_rx = tp->cur_rx;
> -	rx_left = NUM_RX_DESC + tp->dirty_rx - cur_rx;
> -	rx_left = min(rx_left, budget);
>  
> -	for (; rx_left > 0; rx_left--, cur_rx++) {
> +	for (rx_left = min(budget, NUM_RX_DESC); rx_left > 0; rx_left--, cur_rx++) {

Is this really equivalent?  I think cur_rx still needs to be
incorporated into whatever you use as the initial rx_left.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html