netdev - Re: [PATCH net-next 00/11] IPv6: rt->n (neighbour in rt6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130117.153753.1608817353719202851.davem@davemloft.net>
Date:	Thu, 17 Jan 2013 15:37:53 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	yoshfuji@...ux-ipv6.org
Cc:	netdev@...r.kernel.org, xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next 00/11] IPv6: rt->n (neighbour in rt6_info)
 removal (TAKE 3)

From: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Date: Fri, 18 Jan 2013 02:41:41 +0900

> This is "TAKE 3" of neighbour removal from rt6_info.
> 
> 2->3:
> - Removed "icmp6_dst_alloc() removal" patch.
>   This is nothing to do with this series.
> - Removed several unused variables, ifdefs, BUG_ONs.
> - Handled several comments from Cong Wang.
> - Reordered.

This series is almost perfect, great work.

In ip6_output you need to accomodate the fact that __neigh_create()
returns error pointers so it is not valid to simply use a NULL test on
'neigh'.

You'll need to use IS_ERR().  'neigh' can never be NULL here, it is
either a valid non-NULL pointer or a return value from
__neigh_create().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html