netdev - Re: [Patch net-next v4] netpoll: fix a rtnl lock assertion failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1358398403.29723.2.camel@edumazet-glaptop>
Date:	Wed, 16 Jan 2013 20:53:23 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <amwang@...hat.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	jiri@...nulli.us
Subject: Re: [Patch net-next v4] netpoll: fix a rtnl lock assertion failure

On Thu, 2013-01-17 at 12:18 +0800, Cong Wang wrote:

> > Why not just... call dev_get_by_name()?  It doesn't hurt to over-RCU
> > lock.
> > 
> 
> Just that taking RCU read lock while having rtnl lock is unnecessary, no
> other reason.

Calling the dev_get_by_name() would be just fine, and generate less
code.

Its not a fast path...

Anyway David already applied your patch.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html